• Oscar Salvador's avatar
    mm/memory_hotplug.c: make add_memory_resource use __try_online_node · b9ff0360
    Oscar Salvador authored
    This is a small cleanup for the memhotplug code.  A lot more could be
    done, but it is better to start somewhere.  I tried to unify/remove
    duplicated code.
    
    The following is what this patchset does:
    
    1) add_memory_resource() has code to allocate a node in case it was
       offline.  Since try_online_node has some code for that as well, I just
       made add_memory_resource() to use that so we can remove duplicated
       code..  This is better explained in patch 1/4.
    
    2) register_mem_sect_under_node() will be called only from
       link_mem_sections()
    
    3) Make register_mem_sect_under_node() a callback of
       walk_memory_range()
    
    4) Drop unnecessary checks from register_mem_sect_under_node()
    
    I have done some tests and I could not see anything broken because of
    this patchset.
    
    add_memory_resource() contains code to allocate a new node in case it is
    necessary.  Since try_online_node() also has some code for this purpose,
    let us make use of that and remove duplicate code.
    
    This introduces __try_online_node(), which is called by
    add_memory_resource() and try_online_node().  __try_online_node() has
    two new parameters, start_addr of the node, and if the node should be
    onlined and registered right away.  This is always wanted if we are
    calling from do_cpu_up(), but not when we are calling from memhotplug
    code.  Nothing changes from the point of view of the users of
    try_online_node(), since try_online_node passes start_addr=0 and
    online_node=true to __try_online_node().
    
    Link: http://lkml.kernel.org/r/20180622111839.10071-2-osalvador@techadventures.netSigned-off-by: default avatarOscar Salvador <osalvador@suse.de>
    Reviewed-by: default avatarPavel Tatashin <pasha.tatashin@oracle.com>
    Tested-by: default avatarReza Arbab <arbab@linux.vnet.ibm.com>
    Tested-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
    Cc: Pasha Tatashin <Pavel.Tatashin@microsoft.com>
    Cc: Michal Hocko <mhocko@suse.com>
    Cc: Vlastimil Babka <vbabka@suse.cz>
    Cc: Pavel Tatashin <pasha.tatashin@oracle.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    b9ff0360
memory_hotplug.c 49.7 KB