• Tejun Heo's avatar
    cgroup: reorganize cgroup_create() · ba0f4d76
    Tejun Heo authored
    Reorganize cgroup_create() so that all paths share unlock out path.
    
    * All err_* labels are renamed to out_* as they're now shared by both
      success and failure paths.
    
    * @err renamed to @ret for the similar reason as above and so that
      it's more consistent with other functions.
    
    * cgroup memory allocation moved after locking so that freeing failed
      cgroup happens before unlocking.  While this moves more code inside
      critical section, memory allocations inside cgroup locking are
      already pretty common and this is unlikely to make any noticeable
      difference.
    
    * While at it, replace a stray @parent->root dereference with @root.
    
    This reorganization will help simplifying locking.
    Signed-off-by: default avatarTejun Heo <tj@kernel.org>
    Acked-by: default avatarLi Zefan <lizefan@huawei.com>
    ba0f4d76
cgroup.c 145 KB