• Dave Chinner's avatar
    Merge tag 'large-extent-counters-v9' of https://github.com/chandanr/linux into xfs-5.19-for-next · a44a027a
    Dave Chinner authored
    xfs: Large extent counters
    
    The commit xfs: fix inode fork extent count overflow
    (3f8a4f1d) mentions that 10 billion
    data fork extents should be possible to create. However the
    corresponding on-disk field has a signed 32-bit type. Hence this
    patchset extends the per-inode data fork extent counter to 64 bits
    (out of which 48 bits are used to store the extent count).
    
    Also, XFS has an attribute fork extent counter which is 16 bits
    wide. A workload that,
    1. Creates 1 million 255-byte sized xattrs,
    2. Deletes 50% of these xattrs in an alternating manner,
    3. Tries to insert 400,000 new 255-byte sized xattrs
       causes the xattr extent counter to overflow.
    
    Dave tells me that there are instances where a single file has more
    than 100 million hardlinks. With parent pointers being stored in
    xattrs, we will overflow the signed 16-bits wide attribute extent
    counter when large number of hardlinks are created. Hence this
    patchset extends the on-disk field to 32-bits.
    
    The following changes are made to accomplish this,
    1. A 64-bit inode field is carved out of existing di_pad and
       di_flushiter fields to hold the 64-bit data fork extent counter.
    2. The existing 32-bit inode data fork extent counter will be used to
       hold the attribute fork extent counter.
    3. A new incompat superblock flag to prevent older kernels from mounting
       the filesystem.
    Signed-off-by: default avatarChandan Babu R <chandan.babu@oracle.com>
    Signed-off-by: default avatarDave Chinner <david@fromorbit.com>
    a44a027a
xfs_alloc.c 94.9 KB