• Sylwester Nawrocki's avatar
    ARM: dts: exynos: Specify I2S assigned clocks in proper node · badd5690
    Sylwester Nawrocki authored
    commit 8ac686d7 upstream.
    
    The assigned parent clocks should be normally specified in the consumer
    device's DT node, this ensures respective driver always sees correct clock
    settings when required.
    
    This patch fixes regression in audio subsystem on Odroid XU3/XU4 boards
    that appeared after commits:
    
    commit 647d04f8 ("ASoC: samsung: i2s: Ensure the RCLK rate is properly determined")
    commit 995e73e5 ("ASoC: samsung: i2s: Fix rclk_srcrate handling")
    commit 48279c53 ("ASoC: samsung: i2s: Prevent external abort on exynos5433 I2S1 access")
    
    Without this patch the driver gets wrong clock as the I2S function clock
    (op_clk) in probe() and effectively the clock which is finally assigned
    from DT is not being enabled/disabled in the runtime resume/suspend ops.
    
    Without the above listed commits the EXYNOS_I2S_BUS clock was always set
    as parent of CLK_I2S_RCLK_SRC regardless of DT settings so there was no issue
    with not enabled EXYNOS_SCLK_I2S.
    
    Cc: <stable@vger.kernel.org> # 4.17.x
    Signed-off-by: default avatarSylwester Nawrocki <s.nawrocki@samsung.com>
    Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    badd5690
exynos5422-odroidxu4.dts 1.93 KB