• Yasuaki Ishimatsu's avatar
    ACPI / memhotplug: set info->enabled for memory present at boot time · bb49d82d
    Yasuaki Ishimatsu authored
    At http://marc.info/?l=linux-acpi&m=135769405622667&w=2 thread,
    Toshi Kani mentioned as follows:
    
    "I have a question about the change you made in commit 65479472 in
    acpi_memhotplug.c.  This change seems to require that
    acpi_memory_enable_device() calls add_memory() to add all memory ranges
    represented by memory device objects at boot-time, and keep the results
    be used for hot-remove.
    
    If I understand it right, this add_memory() call fails with EEXIST at
    boot-time since all memory ranges should have been added from EFI memory
    table (or e820) already.  This results all memory ranges be marked as !
    enabled & !failed.  I think this means that we cannot hot-delete any
    memory ranges presented at boot-time since acpi_memory_remove_memory()
    only calls remove_memory() when the enabled flag is set.  Is that
    correct?"
    
    Above mention is correct. Thus even if memory device supports hotplug,
    memory presented at boot-time cannot be hot removed since the memory
    device's acpi_memory_info->enabled is always 0.
    
    This patch changes to set 1 to "acpi_memory_info->enabled" of memory
    device presented at boot-time for hot removing the memory device.
    Signed-off-by: default avatarYasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
    Acked-by: default avatarToshi Kani <toshi.kani@hp.com>
    Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
    bb49d82d
acpi_memhotplug.c 8.96 KB