• Gustavo A. R. Silva's avatar
    bpf: verifier: avoid fall-through warnings · ed4ed404
    Gustavo A. R. Silva authored
    In preparation to enabling -Wimplicit-fallthrough, this patch silences
    the following warning:
    
    kernel/bpf/verifier.c: In function ‘check_return_code’:
    kernel/bpf/verifier.c:6106:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
       if (env->prog->expected_attach_type == BPF_CGROUP_UDP4_RECVMSG ||
          ^
    kernel/bpf/verifier.c:6109:2: note: here
      case BPF_PROG_TYPE_CGROUP_SKB:
      ^~~~
    
    Warning level 3 was used: -Wimplicit-fallthrough=3
    
    Notice that is much clearer to explicitly add breaks in each case
    statement (that actually contains some code), rather than letting
    the code to fall through.
    
    This patch is part of the ongoing efforts to enable
    -Wimplicit-fallthrough.
    Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
    Acked-by: default avatarAndrii Nakryiko <andriin@fb.com>
    Signed-off-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
    ed4ed404
verifier.c 268 KB