• John Stultz's avatar
    drm/msm: Fix 0xfffflub in "Refactor address space initialization" · bc8bd54f
    John Stultz authored
    This week I started seeing GPU crashes on my DragonBoard 845c
    which I narrowed down to being caused by commit ccac7ce3
    ("drm/msm: Refactor address space initialization").
    
    Looking through the patch, Jordan and I couldn't find anything
    obviously wrong, so I ended up breaking that change up into a
    number of smaller logical steps so I could figure out which part
    was causing the trouble.
    
    Ends up, visually counting 'f's is hard, esp across a number
    of lines:
      0xfffffff != 0xffffffff
    
    This patch corrects the end value we pass in to
    msm_gem_address_space_create() in
    adreno_iommu_create_address_space() so that it matches the value
    used before the problematic patch landed.
    
    With this change, I no longer see the GPU crashes that were
    affecting me.
    
    Cc: Shawn Guo <shawn.guo@linaro.org>
    Cc: Rob Clark <robdclark@gmail.com>
    Cc: Sean Paul <sean@poorly.run>
    Cc: Jordan Crouse <jcrouse@codeaurora.org>
    Cc: freedreno@lists.freedesktop.org
    Fixes: ccac7ce3 ("drm/msm: Refactor address space initialization")
    Signed-off-by: default avatarJohn Stultz <john.stultz@linaro.org>
    Signed-off-by: default avatarRob Clark <robdclark@chromium.org>
    bc8bd54f
adreno_gpu.c 25.7 KB