• Arnd Bergmann's avatar
    bnx2x: fix format overflow warning · be9cdf1b
    Arnd Bergmann authored
    gcc notices that large queue numbers would overflow the queue name
    string:
    
    drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c: In function 'bnx2x_get_strings':
    drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c:3165:25: error: '%d' directive writing between 1 and 10 bytes into a region of size 5 [-Werror=format-overflow=]
    drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c:3165:25: note: directive argument in the range [0, 2147483647]
    drivers/net/ethernet/broadcom/bnx2x/bnx2x_ethtool.c:3165:5: note: 'sprintf' output between 2 and 11 bytes into a destination of size 5
    
    There is a hard limit in place that makes the number at most two
    digits, so the code is fine. This changes it to use snprintf()
    to truncate instead of overflowing, which shuts up that warning.
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    be9cdf1b
bnx2x_ethtool.c 99.2 KB