• Stephan Gerhold's avatar
    iio: imu: st_lsm6dsx: Fix selection of ST_LSM6DS3_ID · fb4fbc89
    Stephan Gerhold authored
    At the moment, attempting to probe a device with ST_LSM6DS3_ID
    (e.g. using the st,lsm6ds3 compatible) fails with:
    
        st_lsm6dsx_i2c 1-006b: unsupported whoami [69]
    
    ... even though 0x69 is the whoami listed for ST_LSM6DS3_ID.
    
    This happens because st_lsm6dsx_check_whoami() also attempts
    to match unspecified (zero-initialized) entries in the "id" array.
    ST_LSM6DS3_ID = 0 will therefore match any entry in
    st_lsm6dsx_sensor_settings (here: the first), because none of them
    actually have all 12 entries listed in the "id" array.
    
    Avoid this by additionally checking if "name" is set,
    which is only set for valid entries in the "id" array.
    
    Note: Although the problem was introduced earlier it did not surface until
    commit 52f4b1f1 ("iio: imu: st_lsm6dsx: add support for accel/gyro unit of lsm9ds1")
    because ST_LSM6DS3_ID was the first entry in st_lsm6dsx_sensor_settings.
    
    Fixes: d068e4a0 ("iio: imu: st_lsm6dsx: add support to multiple devices with the same settings")
    Cc: <stable@vger.kernel.org> # 5.4
    Acked-by: default avatarLorenzo Bianconi <lorenzo@kernel.org>
    Signed-off-by: default avatarStephan Gerhold <stephan@gerhold.net>
    Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    fb4fbc89
st_lsm6dsx_core.c 52.5 KB