• Joe Lawrence's avatar
    sched/debug: Adjust newlines for better alignment · e9ca2670
    Joe Lawrence authored
    Scheduler debug stats include newlines that display out of alignment
    when prefixed by timestamps.  For example, the dmesg utility:
    
      % echo t > /proc/sysrq-trigger
      % dmesg
      ...
      [   83.124251]
      runnable tasks:
       S           task   PID         tree-key  switches  prio     wait-time
      sum-exec        sum-sleep
      -----------------------------------------------------------------------------------------------------------
    
    At the same time, some syslog utilities (like rsyslog by default) don't
    like the additional newlines control characters, saving lines like this
    to /var/log/messages:
    
      Mar 16 16:02:29 localhost kernel: #012runnable tasks:#012 S           task   PID         tree-key ...
                                        ^^^^               ^^^^
    Clean these up by moving newline characters to their own SEQ_printf
    invocation.  This leaves the /proc/sched_debug unchanged, but brings the
    entire output into alignment when prefixed:
    
      % echo t > /proc/sysrq-trigger
      % dmesg
      ...
      [   62.410368] runnable tasks:
      [   62.410368]  S           task   PID         tree-key  switches  prio     wait-time             sum-exec        sum-sleep
      [   62.410369] -----------------------------------------------------------------------------------------------------------
      [   62.410369]  I  kworker/u12:0     5      1932.215593       332   120         0.000000         3.621252         0.000000 0 0 /
    
    and no escaped control characters from rsyslog in /var/log/messages:
    
      Mar 16 16:15:06 localhost kernel: runnable tasks:
      Mar 16 16:15:06 localhost kernel: S           task   PID         tree-key  ...
    Signed-off-by: default avatarJoe Lawrence <joe.lawrence@redhat.com>
    Acked-by: default avatarPeter Zijlstra <peterz@infradead.org>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Link: http://lkml.kernel.org/r/1521484555-8620-3-git-send-email-joe.lawrence@redhat.comSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
    e9ca2670
debug.c 24.7 KB