• Martin Dalecki's avatar
    [PATCH] 2.5.10 IDE 43 · 5ef2759c
    Martin Dalecki authored
    Some of the following is a bit of sensitive... but anyway it has to be done.
    
    - Scarp "portability" macros ide_request_irq() and ide_free_irq().  What a
       great of a surprise in the face of a kernel nowadays ported to nearly any
       major CPU out there, but apparently no platform needs something special here.
       All of them are just using the normal request_irq() and free_irq(). If some
       unusual platform (read obsolete door blocker) I have overlooked intentionally
       needs something special - please just hack the platform specific
       request_irq() and free_irq()-  they are *far off* from being performance
       relevant. (Hint: You could use cooked default irq values to detect there
       whatever the caller was the ATA driver to decide what to do about it.)
    
    - Kill ide_check_region() ide_request_region() and ide_release_region()
       altogether. Add comments explaining the code there.  Same arguments as above
       apply. Additionally we want to be able at some time to do for example mmapped
       PCI address space access on IA32 instead of port IO.
    
    - Rewrite the initialization code to don't use check_region at all. Add some
       comments there, which explain what's actually happening.
    
    - Fix creeping in of a c99 construct.
    
    - Make the main interrupt handler take a channel as data instead of the
       hwgroup. This is the entity an interrupt is physically associated with. PCI
       interrupt sharing is handled in a generically anyway. Analogously the main
       data entity of a device request queue (q->queuedata) is the device and not
       the hwgroup.  However right now we are only able to push it down to the
       channel level. The intention is to advance the choose_drive() function to
       just check for equal interrupt values for serialization of request and
       thus to get rid of the hwgroup altogether.
    5ef2759c
trm290.c 9.53 KB