• Guilherme G. Piccoli's avatar
    Revert "powerpc/eeh: Fix crash in eeh_add_device_early() on Cell" · c2078d9e
    Guilherme G. Piccoli authored
    This reverts commit 89a51df5.
    
    The function eeh_add_device_early() is used to perform EEH
    initialization in devices added later on the system, like in
    hotplug/DLPAR scenarios. Since the commit 89a51df5 ("powerpc/eeh:
    Fix crash in eeh_add_device_early() on Cell") a new check was introduced
    in this function - Cell has no EEH capabilities which led to kernel oops
    if hotplug was performed, so checking for eeh_enabled() was introduced
    to avoid the issue.
    
    However, in architectures that EEH is present like pSeries or PowerNV,
    we might reach a case in which no PCI devices are present on boot time
    and so EEH is not initialized. Then, if a device is added via DLPAR for
    example, eeh_add_device_early() fails because eeh_enabled() is false,
    and EEH end up not being enabled at all.
    
    This reverts the aforementioned patch since a new verification was
    introduced by the commit d91dafc0 ("powerpc/eeh: Delay probing EEH
    device during hotplug") and so the original Cell issue does not happen
    anymore.
    
    Cc: stable@vger.kernel.org # v4.1+
    Reviewed-by: default avatarGavin Shan <gwshan@linux.vnet.ibm.com>
    Signed-off-by: default avatarGuilherme G. Piccoli <gpiccoli@linux.vnet.ibm.com>
    Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
    c2078d9e
eeh.c 46.3 KB