• Nikolay Borisov's avatar
    btrfs: refactor unlock_up · c1227996
    Nikolay Borisov authored
    The purpose of this function is to unlock all nodes in a btrfs path
    which are above 'lowest_unlock' and whose slot used is different than 0.
    As such it used slightly awkward structure of 'if' as well as somewhat
    cryptic "no_skip" control variable which denotes whether we should
    check the current level of skipability or no.
    
    This patch does the following (cosmetic) refactorings:
    
    * Renames 'no_skip' to 'check_skip' and makes it a boolean. This
      variable controls whether we are below the lowest_unlock/skip_level
      levels.
    
    * Consolidates the 2 conditions which warrant checking whether the
      current level should be skipped under 1 common if (check_skip) branch,
      this increase indentation level but is not critical.
    
    * Consolidates the 'skip_level < i && i >= lowest_unlock' and
      'i >= lowest_unlock && i > skip_level' condition into a common branch
      since those are identical.
    
    * Eliminates the local extent_buffer variable as in this case it doesn't
      bring anything to function readability.
    Reviewed-by: default avatarJosef Bacik <josef@toxicpanda.com>
    Signed-off-by: default avatarNikolay Borisov <nborisov@suse.com>
    Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
    Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
    c1227996
ctree.c 124 KB