• Brian Foster's avatar
    xfs: clear cowblocks tag when cow fork is emptied · c17a8ef4
    Brian Foster authored
    The background cowblocks scan job takes care of scanning for inodes with
    potentially lingering blocks in the cow fork and clearing them out. If
    the background scanner reclaims the cow fork blocks, however, it doesn't
    immediately clear the cowblocks tag from the inode. Instead, the inode
    remains tagged until the background scanner comes around again,
    discovers the inode cow fork has no blocks, clears the tag and fires the
    trace_xfs_inode_free_cowblocks_invalid() tracepoint to indicate that the
    inode may have been incorrectly tagged.
    
    This is not a major functional problem as the tag is ultimately cleared.
    Nonetheless, clear the tag when an inode cow fork is explicitly emptied
    to avoid the extra round trip through the background scanner and
    spurious "invalid" tracepoint.
    Signed-off-by: default avatarBrian Foster <bfoster@redhat.com>
    Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
    Reviewed-by: default avatarDarrick J. Wong <darrick.wong@oracle.com>
    Signed-off-by: default avatarDave Chinner <david@fromorbit.com>
    c17a8ef4
xfs_reflink.c 44.4 KB