• Damien Le Moal's avatar
    block: Fix potential overflow in blk_report_zones() · c1bbef41
    Damien Le Moal authored
    commit 113ab72e upstream.
    
    For large values of the number of zones reported and/or large zone
    sizes, the sector increment calculated with
    
    blk_queue_zone_sectors(q) * n
    
    in blk_report_zones() loop can overflow the unsigned int type used for
    the calculation as both "n" and blk_queue_zone_sectors() value are
    unsigned int. E.g. for a device with 256 MB zones (524288 sectors),
    overflow happens with 8192 or more zones reported.
    
    Changing the return type of blk_queue_zone_sectors() to sector_t, fixes
    this problem and avoids overflow problem for all other callers of this
    helper too. The same change is also applied to the bdev_zone_sectors()
    helper.
    
    Fixes: e76239a3 ("block: add a report_zones method")
    Cc: stable@vger.kernel.org
    Signed-off-by: default avatarDamien Le Moal <damien.lemoal@wdc.com>
    Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    c1bbef41
blk-zoned.c 11.7 KB