• Jacob Keller's avatar
    ice: cleanup allocations in ice_ptp_alloc_tx_tracker · c1f3414d
    Jacob Keller authored
    The ice_ptp_alloc_tx_tracker function must allocate the timestamp array and
    the bitmap for tracking the currently in use indexes. A future change is
    going to add yet another allocation to this function.
    
    If these allocations fail we need to ensure that we properly cleanup and
    ensure that the pointers in the ice_ptp_tx structure are NULL.
    
    Simplify this logic by allocating to local variables first. If any
    allocation fails, then free everything and exit. Only update the ice_ptp_tx
    structure if all allocations succeed.
    
    This ensures that we have no side effects on the Tx structure unless all
    allocations have succeeded. Thus, no code will see an invalid pointer and
    we don't need to re-assign NULL on cleanup.
    
    This is safe because kernel "free" functions are designed to be NULL safe
    and perform no action if passed a NULL pointer. Thus its safe to simply
    always call kfree or bitmap_free even if one of those pointers was NULL.
    Signed-off-by: default avatarJacob Keller <jacob.e.keller@intel.com>
    Tested-by: Gurucharan G <gurucharanx.g@intel.com> (A Contingent worker at Intel)
    Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
    c1f3414d
ice_ptp.c 74.5 KB