• Wen Yang's avatar
    ASoC: samsung: odroid: fix a double-free issue for cpu_dai · 2abee12c
    Wen Yang authored
    The cpu_dai variable is still being used after the of_node_put() call,
    which may result in double-free:
    
            of_node_put(cpu_dai);            ---> released here
    
            ret = devm_snd_soc_register_card(dev, card);
            if (ret < 0) {
    ...
                    goto err_put_clk_i2s;    --> jump to err_put_clk_i2s
    ...
    
    err_put_clk_i2s:
            clk_put(priv->clk_i2s_bus);
    err_put_sclk:
            clk_put(priv->sclk_i2s);
    err_put_cpu_dai:
            of_node_put(cpu_dai);            --> double-free here
    
    Fixes: d832d2b2 ("ASoC: samsung: odroid: Fix of_node refcount unbalance")
    Signed-off-by: default avatarWen Yang <wen.yang99@zte.com.cn>
    Cc: Krzysztof Kozlowski <krzk@kernel.org>
    Cc: Sangbeom Kim <sbkim73@samsung.com>
    Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
    Cc: Liam Girdwood <lgirdwood@gmail.com>
    Cc: Mark Brown <broonie@kernel.org>
    Cc: Jaroslav Kysela <perex@perex.cz>
    Cc: Takashi Iwai <tiwai@suse.com>
    Cc: alsa-devel@alsa-project.org
    Cc: linux-kernel@vger.kernel.org
    Link: https://lore.kernel.org/r/1562989575-33785-3-git-send-email-wen.yang99@zte.com.cnSigned-off-by: default avatarMark Brown <broonie@kernel.org>
    2abee12c
odroid.c 8.87 KB