• Arnd Bergmann's avatar
    ASoC: Intel: haswell depends on sst-firmware · c3474e21
    Arnd Bergmann authored
    The Intel Haswell audio support fails to link if
    CONFIG_SND_SOC_INTEL_SST_FIRMWARE is disabled:
    
    sst-haswell-dsp.c: undefined reference to `sst_mem_block_register'
    sst-haswell-dsp.c: undefined reference to `sst_mem_block_unregister_all'
    sst-haswell-dsp.c: undefined reference to `sst_module_alloc_blocks'
    sst-haswell-dsp.c: undefined reference to `sst_module_free'
    sst-haswell-dsp.c: undefined reference to `sst_module_new'
    sst-haswell-pcm.c: undefined reference to `sst_module_get_from_id'
    sst-haswell-pcm.c: undefined reference to `sst_module_runtime_restore'
    sst-haswell-pcm.c: undefined reference to `sst_module_runtime_save'
    ERROR: "sst_block_alloc_scratch" [sound/soc/intel/haswell/snd-soc-sst-haswell-pcm.ko] undefined!
    ERROR: "sst_block_free_scratch" [sound/soc/intel/haswell/snd-soc-sst-haswell-pcm.ko] undefined!
    ERROR: "sst_dsp_dma_copyfrom" [sound/soc/intel/haswell/snd-soc-sst-haswell-pcm.ko] undefined!
    ERROR: "sst_dsp_dma_copyto" [sound/soc/intel/haswell/snd-soc-sst-haswell-pcm.ko] undefined!
    ERROR: "sst_dsp_dma_get_channel" [sound/soc/intel/haswell/snd-soc-sst-haswell-pcm.ko] undefined!
    ERROR: "sst_dsp_dma_put_channel" [sound/soc/intel/haswell/snd-soc-sst-haswell-pcm.ko] undefined!
    ERROR: "sst_dsp_free" [sound/soc/intel/haswell/snd-soc-sst-haswell-pcm.ko] undefined!
    ERROR: "sst_dsp_get_offset" [sound/soc/intel/haswell/snd-soc-sst-haswell-pcm.ko] undefined!
    ERROR: "sst_dsp_new" [sound/soc/intel/haswell/snd-soc-sst-haswell-pcm.ko] undefined!
    ERROR: "sst_fw_free_all" [sound/soc/intel/haswell/snd-soc-sst-haswell-pcm.ko] undefined!
    ERROR: "sst_fw_new" [sound/soc/intel/haswell/snd-soc-sst-haswell-pcm.ko] undefined!
    ERROR: "sst_fw_reload" [sound/soc/intel/haswell/snd-soc-sst-haswell-pcm.ko] undefined!
    ERROR: "sst_fw_unload" [sound/soc/intel/haswell/snd-soc-sst-haswell-pcm.ko] undefined!
    ERROR: "sst_module_runtime_alloc_blocks" [sound/soc/intel/haswell/snd-soc-sst-haswell-pcm.ko] undefined!
    ERROR: "sst_module_runtime_get_from_id" [sound/soc/intel/haswell/snd-soc-sst-haswell-pcm.ko] undefined!
    ERROR: "sst_module_runtime_new" [sound/soc/intel/haswell/snd-soc-sst-haswell-pcm.ko] undefined!
    
    This moves the 'select' statement from two of the three haswell based users
    into the line that is used by all of them, so make it harder to get wrong
    and to fix the existing randconfig regressions.
    
    Fixes: 2d995e5d ("ASoC: Intel: boards: Add bdw-rt5677 machine driver")
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Signed-off-by: default avatarMark Brown <broonie@kernel.org>
    c3474e21
Kconfig 7.91 KB