• John Hubbard's avatar
    Revert "mm/gup: small refactoring: simplify try_grab_page()" · c36c04c2
    John Hubbard authored
    This reverts commit 54d516b1
    
    That commit did a refactoring that effectively combined fast and slow
    gup paths (again).  And that was again incorrect, for two reasons:
    
     a) Fast gup and slow gup get reference counts on pages in different
        ways and with different goals: see Linus' writeup in commit
        cd1adf1b ("Revert "mm/gup: remove try_get_page(), call
        try_get_compound_head() directly""), and
    
     b) try_grab_compound_head() also has a specific check for
        "FOLL_LONGTERM && !is_pinned(page)", that assumes that the caller
        can fall back to slow gup. This resulted in new failures, as
        recently report by Will McVicker [1].
    
    But (a) has problems too, even though they may not have been reported
    yet.  So just revert this.
    
    Link: https://lore.kernel.org/r/20220131203504.3458775-1-willmcvicker@google.com [1]
    Fixes: 54d516b1 ("mm/gup: small refactoring: simplify try_grab_page()")
    Reported-and-tested-by: default avatarWill McVicker <willmcvicker@google.com>
    Cc: Christoph Hellwig <hch@lst.de>
    Cc: Minchan Kim <minchan@google.com>
    Cc: Matthew Wilcox <willy@infradead.org>
    Cc: Christian Borntraeger <borntraeger@de.ibm.com>
    Cc: Heiko Carstens <hca@linux.ibm.com>
    Cc: Vasily Gorbik <gor@linux.ibm.com>
    Cc: stable@vger.kernel.org # 5.15
    Signed-off-by: default avatarJohn Hubbard <jhubbard@nvidia.com>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    c36c04c2
gup.c 90.3 KB