• Neil Horman's avatar
    x86, kexec: fix hang on i386 when panic occurs while console_sem is held · cf52ebed
    Neil Horman authored
    There's a corner case in 32 bit x86 kdump at the moment.  When the box
    panics via nmi, we call bust_spinlocks(1) to disable sensitivity to the
    console_sem (allowing us to print to the console in all cases), but we don't
    call crash_kexec, until after we call bust_spinlocks(0), which re-enables
    console_sem sensitivity.
    
    The result is that, if we get an nmi while the console_sem is held and
    kdump is configured, and we try to print something to the console during
    kdump shutdown (which we often do) we deadlock the box.  The fix is to
    simply do what 64 bit die_nmi does which is to not call bust_spinlocks(0)
    until after we call crash_kexec.
    
    Patch below tested successfully by me.
    Signed-off-by: default avatarNeil Horman <nhorman@tuxdriver.com>
    Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
    cf52ebed
dumpstack_32.c 9.69 KB