• Sergei Shtylyov's avatar
    [MIPS] Pb1200/DBAu1200 code style cleanup · c3d1d5c8
    Sergei Shtylyov authored
    Fix several errors and warnings given by checkpatch.pl:
    
    - use of C99 // comments;
    
    - initialization of a 'static' variable to 0;
    
    - space after opening and before closing parentheses;
    
    - missing space between 'for' and opening parenthesis;
    
    - macros with complex values not enclosed in parentheses;
    
    - printk() without KERN_* facility level;
    
    - unnecessary braces for single-statement block;
    
    - using simple_strtol() where strict_strtol() could be used;
    
    - line over 80 characters.
    
    In addition to these changes, also do the following:
    
    - mention DBAu1200 board in the Makefile;
    
    - replace the group of #include/#ifdef directives by a single
      #include <au1xxx.h> since this header contains the needed stuff;
    
    - properly indent the blocks;
    
    - insert spaces between operator and its operands, remove excess spaces
      there;
    
    - remove needless parentheses and add some for clarity;
    
    - replace numeric literals/expressions with the matching macros;
    
    - remove space after the type cast's closing parenthesis;
    
    - reduce pb1200_setup_cascade() to the single 'return' statement;
    
    - reduce the number of printed empty lines in the so-called CPLD
      workaround;
    
    - remove #undef AU1X00_EXTERNAL_INT since that macro is not defined
      anywhere;
    
    - replace spaces after the macro name with tabs in the #define directives;
    
    - remove excess tabs after the macro name in the #define directives;
    
    - fix typo in the BCSR_RESETS_PWMR1mUX macro's name;
    
    - group all Pb1200 PCMCIA definitions together;
    
    - put the function's result type and name/parameters on the same line;
    
    - insert missing and remove excess new lines;
    
    - make the multi-line comment style consistent with the kernel style
      elsewhere by adding empty first line and/or adding space/asterisk on
      their left side;
    
    - fix typos/errors, capitalize acronyms, etc. in the comments;
    
    - combine some comments;
    
    - update MontaVista copyright;
    
    - remove Pete Popov's old email address...
    Signed-off-by: default avatarSergei Shtylyov <sshtylyov@ru.mvista.com>
    Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
    c3d1d5c8
db1200.h 5.97 KB