• Arnd Bergmann's avatar
    staging: rtl8723bs: fix empty-body warning · c45112e4
    Arnd Bergmann authored
    The newly added driver causes lots of warnings like
    
    drivers/staging/rtl8723bs/core/rtw_recv.c: In function 'validate_recv_frame':
    drivers/staging/rtl8723bs/core/rtw_recv.c:1602:4: error: suggest braces around empty body in an 'else' statement [-Werror=empty-body]
        DBG_COUNTER(adapter->rx_logs.core_rx_pre_data_handled);
    drivers/staging/rtl8723bs/core/rtw_xmit.c: In function 'update_attrib':
    drivers/staging/rtl8723bs/core/rtw_xmit.c:726:3: error: suggest braces around empty body in an 'else' statement [-Werror=empty-body]
       DBG_COUNTER(padapter->tx_logs.core_tx_upd_attrib_unknown);
    drivers/staging/rtl8723bs/hal/HalPhyRf.c: In function 'ODM_TXPowerTrackingCallback_ThermalMeter':
    drivers/staging/rtl8723bs/hal/HalPhyRf.c:146:4: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body]
    drivers/staging/rtl8723bs/hal/HalPhyRf.c:529:6: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body]
    drivers/staging/rtl8723bs/hal/HalPhyRf.c:559:6: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body]
    
    When DBG_COUNTER() etc is defined as a non-empty macro, we get the intended
    behavior and no warning. Using no_printk() for printing helper functions
    as the added advantage of compile-time checking format strings
    
    Fixes: 554c0a3a ("staging: Add rtl8723bs sdio wifi driver")
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
    c45112e4
rtw_debug.h 12.6 KB