• Arnd Bergmann's avatar
    mt76: mt7915: fix unused 'mode' variable · c490492f
    Arnd Bergmann authored
    clang points out a possible corner case in the mt7915_tm_set_tx_cont()
    function if called with invalid arguments:
    
    drivers/net/wireless/mediatek/mt76/mt7915/testmode.c:593:2: warning: variable 'mode' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
            default:
            ^~~~~~~
    drivers/net/wireless/mediatek/mt76/mt7915/testmode.c:597:13: note: uninitialized use occurs here
            rateval =  mode << 6 | rate_idx;
                       ^~~~
    drivers/net/wireless/mediatek/mt76/mt7915/testmode.c:506:37: note: initialize the variable 'mode' to silence this warning
            u8 rate_idx = td->tx_rate_idx, mode;
                                               ^
    
    Change it to return an error instead of continuing with invalid data
    here.
    
    Fixes: 3f0caa3c ("mt76: mt7915: add support for continuous tx in testmode")
    Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
    Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
    c490492f
testmode.c 17.7 KB