• Maxim Mikityanskiy's avatar
    net/tls: Fix use-after-free after the TLS device goes down and up · c55dcdd4
    Maxim Mikityanskiy authored
    When a netdev with active TLS offload goes down, tls_device_down is
    called to stop the offload and tear down the TLS context. However, the
    socket stays alive, and it still points to the TLS context, which is now
    deallocated. If a netdev goes up, while the connection is still active,
    and the data flow resumes after a number of TCP retransmissions, it will
    lead to a use-after-free of the TLS context.
    
    This commit addresses this bug by keeping the context alive until its
    normal destruction, and implements the necessary fallbacks, so that the
    connection can resume in software (non-offloaded) kTLS mode.
    
    On the TX side tls_sw_fallback is used to encrypt all packets. The RX
    side already has all the necessary fallbacks, because receiving
    non-decrypted packets is supported. The thing needed on the RX side is
    to block resync requests, which are normally produced after receiving
    non-decrypted packets.
    
    The necessary synchronization is implemented for a graceful teardown:
    first the fallbacks are deployed, then the driver resources are released
    (it used to be possible to have a tls_dev_resync after tls_dev_del).
    
    A new flag called TLS_RX_DEV_DEGRADED is added to indicate the fallback
    mode. It's used to skip the RX resync logic completely, as it becomes
    useless, and some objects may be released (for example, resync_async,
    which is allocated and freed by the driver).
    
    Fixes: e8f69799 ("net/tls: Add generic NIC offload infrastructure")
    Signed-off-by: default avatarMaxim Mikityanskiy <maximmi@nvidia.com>
    Reviewed-by: default avatarTariq Toukan <tariqt@nvidia.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    c55dcdd4
tls_device.c 35.9 KB