• Mark Rutland's avatar
    arm64: remove __die()'s stack dump · c5bc503c
    Mark Rutland authored
    Our __die() implementation tries to dump the stack memory, in addition
    to a backtrace, which is problematic.
    
    For contemporary 16K stacks, this can be a lot of data, which can take a
    long time to dump, and can push other useful context out of the kernel's
    printk ringbuffer (and/or a user's scrollback buffer on an attached
    console).
    
    Additionally, the code implicitly assumes that the SP is on the task's
    stack, and tries to dump everything between the SP and the highest task
    stack address. When the SP points at an IRQ stack (or is corrupted),
    this makes the kernel attempt to dump vast amounts of VA space. With
    vmap'd stacks, this may result in erroneous accesses to peripherals.
    
    This patch removes the memory dump, leaving us to rely on the backtrace,
    and other means of dumping stack memory such as kdump.
    Signed-off-by: default avatarMark Rutland <mark.rutland@arm.com>
    Reviewed-by: default avatarWill Deacon <will.deacon@arm.com>
    Tested-by: default avatarLaura Abbott <labbott@redhat.com>
    Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
    Cc: Catalin Marinas <catalin.marinas@arm.com>
    Cc: James Morse <james.morse@arm.com>
    c5bc503c
traps.c 18 KB