• Girish Moodalbail's avatar
    geneve: use netlink_ext_ack for error reporting in rtnl operations · c5ebc440
    Girish Moodalbail authored
    Add extack error messages for failure paths while creating/modifying
    geneve devices. Once extack support is added to iproute2, more
    meaningful and helpful error messages will be displayed making it easy
    for users to discern what went wrong.
    
    Before:
    
    =======
    $ ip link add gen1 address 0:1:2:3:4:5:6 type geneve id 200 \
      remote 192.168.13.2
    RTNETLINK answers: Invalid argument
    
    After:
    ======
    $ ip link add gen1 address 0:1:2:3:4:5:6 type geneve id 200 \
      remote 192.168.13.2
    Error: Provided link layer address is not Ethernet
    
    Also, netdev_dbg() calls used to log errors associated with Netlink
    request have been removed.
    Signed-off-by: default avatarGirish Moodalbail <girish.moodalbail@oracle.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    c5ebc440
geneve.c 44.1 KB