• Alexander Duyck's avatar
    tcp: Fix truesize accounting in tcp_try_coalesce · c73c3d9c
    Alexander Duyck authored
    This patch addresses several issues in the way we were tracking the
    truesize in tcp_try_coalesce.
    
    First it was using ksize which prevents us from having a 0 sized head frag
    and getting a usable result.  To resolve that this patch uses the end
    pointer which is set based off either ksize, or the frag_size supplied in
    build_skb.  This allows us to compute the original truesize of the entire
    buffer and remove that value leaving us with just what was added as pages.
    
    The second issue was the use of skb->len if there is a mergeable head frag.
    We should only need to remove the size of an data aligned sk_buff from our
    current skb->truesize to compute the delta for a buffer with a reused head.
    By using skb->len the value of truesize was being artificially reduced
    which means that head frags could use more memory than buffers using
    standard allocations.
    Signed-off-by: default avatarAlexander Duyck <alexander.h.duyck@intel.com>
    Cc: Eric Dumazet <edumazet@google.com>
    Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
    Acked-by: default avatarEric Dumazet <edumazet@google.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    c73c3d9c
tcp_input.c 177 KB