• Stephan Gerhold's avatar
    arm64: dts: qcom: msm8916: Fix Secondary MI2S bit clock · 8199a0b3
    Stephan Gerhold authored
    At the moment, playing audio on Secondary MI2S will just end up getting
    stuck, without actually playing any audio. This happens because the wrong
    bit clock is configured when playing audio on Secondary MI2S.
    
    The PRI_I2S_CLK (better name: SPKR_I2S_CLK) is used by the SPKR audio mux
    block that provides both Primary and Secondary MI2S.
    
    The SEC_I2S_CLK (better name: MIC_I2S_CLK) is used by the MIC audio mux
    block that provides Tertiary MI2S. Quaternary MI2S is also part of the
    MIC audio mux but has its own clock (AUX_I2S_CLK).
    
    This means that (quite confusingly) the SEC_I2S_CLK is not actually
    used for Secondary MI2S as the name would suggest. Secondary MI2S
    needs to have the same clock as Primary MI2S configured.
    
    Fix the clock list for the lpass node in the device tree and add
    a comment to clarify this confusing naming. With these changes,
    audio can be played correctly on Secondary MI2S.
    
    Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
    Fixes: 3761a361 ("arm64: dts: qcom: add lpass node")
    Tested-by: default avatarVincent Knecht <vincent.knecht@mailoo.org>
    Signed-off-by: default avatarStephan Gerhold <stephan@gerhold.net>
    Signed-off-by: default avatarBjorn Andersson <bjorn.andersson@linaro.org>
    Link: https://lore.kernel.org/r/20210816181810.2242-1-stephan@gerhold.net
    8199a0b3
msm8916.dtsi 45.2 KB