• Hugh Dickins's avatar
    mm/memory: handle_pte_fault() use pte_offset_map_nolock() · c7ad0880
    Hugh Dickins authored
    handle_pte_fault() use pte_offset_map_nolock() to get the vmf.ptl which
    corresponds to vmf.pte, instead of pte_lockptr() being used later, when
    there's a chance that the pmd entry might have changed, perhaps to none,
    or to a huge pmd, with no split ptlock in its struct page.
    
    Remove its pmd_devmap_trans_unstable() call: pte_offset_map_nolock() will
    handle that case by failing.  Update the "morph" comment above, looking
    forward to when shmem or file collapse to THP may not take mmap_lock for
    write (or not at all).
    
    do_numa_page() use the vmf->ptl from handle_pte_fault() at first, but
    refresh it when refreshing vmf->pte.
    
    do_swap_page()'s pte_unmap_same() (the thing that takes ptl to verify a
    two-part PAE orig_pte) use the vmf->ptl from handle_pte_fault() too; but
    do_swap_page() is also used by anon THP's __collapse_huge_page_swapin(),
    so adjust that to set vmf->ptl by pte_offset_map_nolock().
    
    Link: https://lkml.kernel.org/r/c1107654-3929-60ac-223e-6877cbb86065@google.comSigned-off-by: default avatarHugh Dickins <hughd@google.com>
    Cc: Alistair Popple <apopple@nvidia.com>
    Cc: Anshuman Khandual <anshuman.khandual@arm.com>
    Cc: Axel Rasmussen <axelrasmussen@google.com>
    Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
    Cc: Christoph Hellwig <hch@infradead.org>
    Cc: David Hildenbrand <david@redhat.com>
    Cc: "Huang, Ying" <ying.huang@intel.com>
    Cc: Ira Weiny <ira.weiny@intel.com>
    Cc: Jason Gunthorpe <jgg@ziepe.ca>
    Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
    Cc: Lorenzo Stoakes <lstoakes@gmail.com>
    Cc: Matthew Wilcox <willy@infradead.org>
    Cc: Mel Gorman <mgorman@techsingularity.net>
    Cc: Miaohe Lin <linmiaohe@huawei.com>
    Cc: Mike Kravetz <mike.kravetz@oracle.com>
    Cc: Mike Rapoport (IBM) <rppt@kernel.org>
    Cc: Minchan Kim <minchan@kernel.org>
    Cc: Naoya Horiguchi <naoya.horiguchi@nec.com>
    Cc: Pavel Tatashin <pasha.tatashin@soleen.com>
    Cc: Peter Xu <peterx@redhat.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Qi Zheng <zhengqi.arch@bytedance.com>
    Cc: Ralph Campbell <rcampbell@nvidia.com>
    Cc: Ryan Roberts <ryan.roberts@arm.com>
    Cc: SeongJae Park <sj@kernel.org>
    Cc: Song Liu <song@kernel.org>
    Cc: Steven Price <steven.price@arm.com>
    Cc: Suren Baghdasaryan <surenb@google.com>
    Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
    Cc: Will Deacon <will@kernel.org>
    Cc: Yang Shi <shy828301@gmail.com>
    Cc: Yu Zhao <yuzhao@google.com>
    Cc: Zack Rusin <zackr@vmware.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    c7ad0880
memory.c 161 KB