• Jensen's avatar
    ocfs2: llseek requires ocfs2 inode lock for the file in SEEK_END · c8d888d9
    Jensen authored
    llseek requires ocfs2 inode lock for updating the file size in SEEK_END.
    because the file size maybe update on another node.
    
    This bug can be reproduce the following scenario: at first, we dd a test
    fileA, the file size is 10k.
    
    on NodeA:
    ---------
     1) open the test fileA, lseek the end of file. and print the position.
     2) close the test fileA
    
    on NodeB:
     1) open the test fileA, append the 5k data to test FileA.
     2) lseek the end of file. and print the position.
     3) close file.
    
    At first we run the test program1 on NodeA , the result is 10k.  And
    then run the test program2 on NodeB, the result is 15k.  At last, we run
    the test program1 on NodeA again, the result is 10k.
    
    After applying this patch the three step result is 15k.
    
    test result: 1000000 times lseek call;
    index        lseek with inode lock (unit:us)                lseek without inode lock (unit:us)
      1                   1168162                                    555383
      2                   1168011                                    549504
      3                   1170538                                    549396
      4                   1170375                                    551685
      5                   1170444                                    556719
      6                   1174364                                    555307
      7                   1163294                                    551552
      8                   1170080                                    549350
      9                   1162464                                    553700
     10                   1165441                                    552594
     avg                  1168317                                    552519
    
    avg with lock - avg without lock = 615798
    (avg with lock - avg without lock)/1000000=0.615798 us
    Signed-off-by: default avatarJensen <shencanquan@huawei.com>
    Cc: Jie Liu <jeff.liu@oracle.com>
    Acked-by: default avatarJoel Becker <jlbec@evilplan.org>
    Cc: Mark Fasheh <mfasheh@suse.com>
    Cc: Sunil Mushran <sunil.mushran@gmail.com>
    Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    c8d888d9
file.c 66.4 KB