• Nicholas Piggin's avatar
    powerpc/64s/radix: Fix missing ptesync in flush_cache_vmap · ff5bc793
    Nicholas Piggin authored
    There is a typo in f1cb8f9b ("powerpc/64s/radix: avoid ptesync after
    set_pte and ptep_set_access_flags") config ifdef, which results in the
    necessary ptesync not being issued after vmalloc.
    
    This causes random kernel faults in module load, bpf load, anywhere
    that vmalloc mappings are used.
    
    After correcting the code, this survives a guest kernel booting
    hundreds of times where previously there would be a crash every few
    boots (I haven't noticed the crash on host, perhaps due to different
    TLB and page table walking behaviour in hardware).
    
    A memory clobber is also added to the flush, just to be sure it won't
    be reordered with the pte set or the subsequent mapping access.
    
    Fixes: f1cb8f9b ("powerpc/64s/radix: avoid ptesync after set_pte and ptep_set_access_flags")
    Signed-off-by: default avatarNicholas Piggin <npiggin@gmail.com>
    Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
    ff5bc793
cacheflush.h 4.18 KB