• Filipe Manana's avatar
    Btrfs: send, account for orphan directories when building path strings · c992ec94
    Filipe Manana authored
    If we have directories with a pending move/rename operation, we must take into
    account any orphan directories that got created before executing the pending
    move/rename. Those orphan directories are directories with an inode number higher
    then the current send progress and that don't exist in the parent snapshot, they
    are created before current progress reaches their inode number, with a generated
    name of the form oN-M-I and at the root of the filesystem tree, and later when
    progress matches their inode number, moved/renamed to their final location.
    
    Reproducer:
    
              $ mkfs.btrfs -f /dev/sdd
              $ mount /dev/sdd /mnt
    
              $ mkdir -p /mnt/a/b/c/d
              $ mkdir /mnt/a/b/e
              $ mv /mnt/a/b/c /mnt/a/b/e/CC
              $ mkdir /mnt/a/b/e/CC/d/f
    	  $ mkdir /mnt/a/g
    
              $ btrfs subvolume snapshot -r /mnt /mnt/snap1
              $ btrfs send /mnt/snap1 -f /tmp/base.send
    
              $ mkdir /mnt/a/g/h
    	  $ mv /mnt/a/b/e /mnt/a/g/h/EE
              $ mv /mnt/a/g/h/EE/CC/d /mnt/a/g/h/EE/DD
    
              $ btrfs subvolume snapshot -r /mnt /mnt/snap2
              $ btrfs send -p /mnt/snap1 /mnt/snap2 -f /tmp/incremental.send
    
    The second receive command failed with the following error:
    
        ERROR: rename a/b/e/CC/d -> o264-7-0/EE/DD failed. No such file or directory
    
    A test case for xfstests follows soon.
    Signed-off-by: default avatarFilipe David Borba Manana <fdmanana@gmail.com>
    Signed-off-by: default avatarChris Mason <clm@fb.com>
    c992ec94
send.c 132 KB