• Zachary Amsden's avatar
    KVM: x86: Add clock sync request to hardware enable · ca84d1a2
    Zachary Amsden authored
    If there are active VCPUs which are marked as belonging to
    a particular hardware CPU, request a clock sync for them when
    enabling hardware; the TSC could be desynchronized on a newly
    arriving CPU, and we need to recompute guests system time
    relative to boot after a suspend event.
    
    This covers both cases.
    
    Note that it is acceptable to take the spinlock, as either
    no other tasks will be running and no locks held (BSP after
    resume), or other tasks will be guaranteed to drop the lock
    relatively quickly (AP on CPU_STARTING).
    
    Noting we now get clock synchronization requests for VCPUs
    which are starting up (or restarting), it is tempting to
    attempt to remove the arch/x86/kvm/x86.c CPU hot-notifiers
    at this time, however it is not correct to do so; they are
    required for systems with non-constant TSC as the frequency
    may not be known immediately after the processor has started
    until the cpufreq driver has had a chance to run and query
    the chipset.
    
    Updated: implement better locking semantics for hardware_enable
    
    Removed the hack of dropping and retaking the lock by adding the
    semantic that we always hold kvm_lock when hardware_enable is
    called.  The one place that doesn't need to worry about it is
    resume, as resuming a frozen CPU, the spinlock won't be taken.
    Signed-off-by: default avatarZachary Amsden <zamsden@redhat.com>
    Signed-off-by: default avatarMarcelo Tosatti <mtosatti@redhat.com>
    ca84d1a2
x86.c 142 KB