• Vlastimil Babka's avatar
    slub/kunit: skip test_kfree_rcu when the slub kunit test is built-in · cac39b07
    Vlastimil Babka authored
    Guenter Roeck reports that the new slub kunit tests added by commit
    4e1c44b3 ("kunit, slub: add test_kfree_rcu() and
    test_leak_destroy()") cause a lockup on boot on several architectures
    when the kunit tests are configured to be built-in and not modules.
    
    The test_kfree_rcu test invokes kfree_rcu() and boot sequence inspection
    showed the runner for built-in kunit tests kunit_run_all_tests() is
    called before setting system_state to SYSTEM_RUNNING and calling
    rcu_end_inkernel_boot(), so this seems like a likely cause. So while I
    was unable to reproduce the problem myself, skipping the test when the
    slub_kunit module is built-in should avoid the issue.
    
    An alternative fix that was moving the call to kunit_run_all_tests() a
    bit later in the boot was tried, but has broken tests with functions
    marked as __init due to free_initmem() already being done.
    
    Fixes: 4e1c44b3 ("kunit, slub: add test_kfree_rcu() and test_leak_destroy()")
    Reported-by: default avatarGuenter Roeck <linux@roeck-us.net>
    Closes: https://lore.kernel.org/all/6fcb1252-7990-4f0d-8027-5e83f0fb9409@roeck-us.net/
    Cc: Paul E. McKenney <paulmck@kernel.org>
    Cc: Boqun Feng <boqun.feng@gmail.com>
    Cc: Uladzislau Rezki <urezki@gmail.com>
    Cc: rcu@vger.kernel.org
    Cc: Brendan Higgins <brendanhiggins@google.com>
    Cc: David Gow <davidgow@google.com>
    Cc: Rae Moar <rmoar@google.com>
    Cc: linux-kselftest@vger.kernel.org
    Cc: kunit-dev@googlegroups.com
    Tested-by: default avatarGuenter Roeck <linux@roeck-us.net>
    Signed-off-by: default avatarVlastimil Babka <vbabka@suse.cz>
    cac39b07
slub_kunit.c 5.19 KB