• Dan Carpenter's avatar
    orangefs: silence harmless integer overflow warning · eb82fbcf
    Dan Carpenter authored
    The issue here is that in orangefs_bufmap_alloc() we do:
    
    	bufmap->buffer_index_array =
    		kzalloc(DIV_ROUND_UP(bufmap->desc_count, BITS_PER_LONG), GFP_KERNEL);
    
    If we choose a bufmap->desc_count like -31 then it means the
    DIV_ROUND_UP ends up having an integer overflow.   The result is that
    kzalloc() returns the ZERO_SIZE_PTR and there is a static checker
    warning.
    
    But this bug is harmless because on the next lines we use ->desc_count
    to do a kcalloc().  That has integer overflow checking built in so the
    kcalloc() fails and we return an error code.
    
    Anyway, it doesn't make sense to talk about negative sizes and blocking
    them silences the static checker warning.
    Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: default avatarMike Marshall <hubcap@omnibond.com>
    eb82fbcf
orangefs-bufmap.c 12.7 KB