• Thierry Reding's avatar
    drm/tegra: Remove gratuitous pad field · cbfbbabb
    Thierry Reding authored
    The version of the drm_tegra_submit structure that was merged all the
    way back in 3.10 contains a pad field that was originally intended to
    properly pad the following __u64 field. Unfortunately it seems like a
    different field was dropped during review that caused this padding to
    become unnecessary, but the pad field wasn't removed at that time.
    
    One possible side-effect of this is that since the __u64 following the
    pad is now no longer properly aligned, the compiler may (or may not)
    introduce padding itself, which results in no predictable ABI.
    
    Rectify this by removing the pad field so that all fields are again
    naturally aligned. Technically this is breaking existing userspace ABI,
    but given that there aren't any (released) userspace drivers that make
    use of this yet, the fallout should be minimal.
    
    Fixes: d43f81cb ("drm/tegra: Add gr2d device")
    Cc: <stable@vger.kernel.org> # 3.10
    Signed-off-by: default avatarThierry Reding <treding@nvidia.com>
    cbfbbabb
tegra_drm.h 4.13 KB