• Hans de Goede's avatar
    ASoC: rt5670: Add emulated 'DAC1 Playback Switch' control · 42121c26
    Hans de Goede authored
    For reliable output-mute LED control we need a "DAC1 Playback Switch"
    control. The "DAC Playback volume" control is the only control in the
    path from the DAC1 data input to the speaker output, so the UCM profile
    for the speaker output will have its PlaybackMixerElem set to "DAC1".
    
    But userspace (pulseaudio) will set the "DAC1 Playback Volume" control to
    its softest setting (which is not fully muted) while still showing the
    speaker as being enabled at a low volume in the UI.
    
    If we were to set the SNDRV_CTL_ELEM_ACCESS_SPK_LED on the "DAC1 Playback
    Volume" control, this would mean then what pressing KEY_VOLUMEDOWN the
    speaker-mute LED (embedded in the volume-mute toggle key) would light
    while the UI is still showing the speaker as being enabled at a low
    volume, meaning that the UI and the LED are out of sync.
    
    Only after an _extra_ KEY_VOLUMEDOWN press would the UI show the
    speaker as being muted.
    
    The path from DAC1 data input to the speaker output does have
    a digital mixer with DAC1's data as one of its inputs direclty after
    the "DAC1 Playback Volume" control.
    
    This commit adds an emulated "DAC1 Playback Switch" control by:
    
    1. Declaring the enable flag for that mixers DAC1 input as well as the
    "DAC1 Playback Switch" control both as SND_SOC_NOPM controls.
    
    2. Storing the settings of both controls as driver-private data
    
    3. Only clearing the mute flag for the DAC1 input of that mixer if the
    stored values indicate both controls are enabled.
    
    This is a preparation patch for adding "audio-mute" LED trigger support.
    Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
    Link: https://lore.kernel.org/r/20210215142118.308516-5-hdegoede@redhat.comSigned-off-by: default avatarMark Brown <broonie@kernel.org>
    42121c26
rt5670.c 100 KB