• Arjan van de Ven's avatar
    [PATCH] lockdep: annotate hostap netdev ->xmit_lock · cd11acdd
    Arjan van de Ven authored
    On Fri, 2006-06-30 at 15:45 -0700, Miles Lane wrote:
    > Okay, I rebuilt my kernel with your combo patch applied.
    > Then, I inserted my US Robotics USR2210 PCMCIA wifi card,
    > ran "pccardutil eject", popped out the card and then inserted
    > a Compaq iPaq wifi card.  This triggered the following.
    >
    > [ INFO: possible circular locking dependency detected ]
    > -------------------------------------------------------
    > syslogd/1886 is trying to acquire lock:
    >  (&dev->queue_lock){-+..}, at: [<c11a50b5>] dev_queue_xmit+0x120/0x24b
    >
    > but task is already holding lock:
    >  (&dev->_xmit_lock){-+..}, at: [<c11a5118>] dev_queue_xmit+0x183/0x24b
    >
    > which lock already depends on the new lock.
    
    ok this appears to be hostap playing games... it has 2 network devices
    for one piece of hardware and one calls the other via the networking
    layer; there is thankfully a natural ordering between the two, so just
    making the slave one a separate type ought to make this work.
    Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
    Cc: Arjan van de Ven <arjan@linux.intel.com>
    Cc: "John W. Linville" <linville@tuxdriver.com>
    Cc: Jeff Garzik <jeff@garzik.org>
    Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
    Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
    cd11acdd
hostap_hw.c 93.8 KB