• Cheng Renquan's avatar
    scripts/kconfig/nconf: fix memmove's length arg · cd58a90f
    Cheng Renquan authored
    In case KEY_BACKSPACE / KEY_DC to delete a char, it memmove only
    (len-cursor_position+1) bytes;
    the default case is to insert a char, it should also memmove exactly
    (len-cursor_position+1) bytes;
    
    the original use of (len+1) is wrong and may access following memory
    that doesn't belong to result, may cause SegFault in theory;
    
    	case KEY_BACKSPACE:
    		if (cursor_position > 0) {
    			memmove(&result[cursor_position-1],
    					&result[cursor_position],
    					len-cursor_position+1);
    			cursor_position--;
    		}
    		break;
    	case KEY_DC:
    		if (cursor_position >= 0 && cursor_position < len) {
    			memmove(&result[cursor_position],
    					&result[cursor_position+1],
    					len-cursor_position+1);
    		}
    		break;
    	default:
    		if ((isgraph(res) || isspace(res)) &&
    				len-2 < result_len) {
    			/* insert the char at the proper position */
    			memmove(&result[cursor_position+1],
    					&result[cursor_position],
    					len-cursor_position+1);
    			result[cursor_position] = res;
    			cursor_position++;
    		}
    Signed-off-by: default avatarCheng Renquan <crquan@gmail.com>
    Acked-by: default avatarNir Tzachar <nir.tzachar@gmail.com>
    cd58a90f
nconf.gui.c 13.6 KB