• Sam Ravnborg's avatar
    sparc32: remove cast from output constraints in math asm statements · 347b0cf0
    Sam Ravnborg authored
    The following asm statements generated a sparse warning:
    
            asm("addcc \n\t" : "=r" (((USItype)(r2)))
    
    warning: asm output is not an lvalue
    
    When asking on the sparse mailing list Linus replyed:
    
    "
    Those casts to (USItype) are all pointless to begin with (since the
    values are of that type already!) and they mean that the expression
    isn't something you can assign to (lvalue).
    "
    
    In the math emulation code drop all casts in the output
    parts of the asm statements.
    
    This fixes a lot of "warning: asm output is not an lvalue" sparse
    warnings in math_32.c.
    Signed-off-by: default avatarSam Ravnborg <sam@ravnborg.org>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    347b0cf0
sfp-util_32.h 3.65 KB