• Nishanth Menon's avatar
    regulator: palmas: Fix SMPS list for 0V · 6b7f2d82
    Nishanth Menon authored
    get_voltage_sel reads from SMPS register - if the read selector value
    is 0, the SMPS is actually disabled - So, this is in addition to the
    ctrl_register that may also be used to enable/disable the SMPS.
    
    The original logic(prior to commit dbabd624) used to be:
    static int palmas_map_voltage_smps(struct regulator_dev *rdev,
                   int min_uV, int max_uV)
    <snip>
           if (min_uV == 0)
                   return 0;
    
    To handle this scenario, with the transition to regulator_list
    implementation, we seem to have missed the data necessary to mark as
    one of the valid entries as "0" 'disabled regulator' which results in
    0 volts - So, stick with pre-existing logic.
    
    Without this added to the list, palmas regulator driver,
    on probe, attempts to setup constraints and in the case of
    OMAP5uEVM, SMPS9 (which is mapped for 2v1 audio supply) fails in
    regulator_list_voltage_linear_range mapping of '0', and as a fall back
    of constraints not being applied, the entire regulator list is not
    enumerated due to assumption that something system wide has gone bad
    on with the PMIC.
    
    Fixes: dbabd624 ("regulator: palmas: Reemove open coded functions with helper functions")
    Reported-by: default avatarOlof Johansson <olof@lixom.net>
    Signed-off-by: default avatarNishanth Menon <nm@ti.com>
    Signed-off-by: default avatarMark Brown <broonie@linaro.org>
    6b7f2d82
palmas-regulator.c 28.8 KB