• Masami Hiramatsu's avatar
    perf probe: Improve error messages in --line option · 5ee05b88
    Masami Hiramatsu authored
    Improve error messages of 'perf probe --line' mode.
    
    Currently 'perf probe' shows the "Debuginfo analysis failed" message with
    an error code when the given symbol is not found:
    
      -----
      # perf probe -L page_cgroup_init_flatmem
      Debuginfo analysis failed. (-2)
        Error: Failed to show lines.
      -----
    
    But -2 (-ENOENT) means that the given source line or function was not
    found. With this patch, 'perf probe' shows the correct error message:
    
      -----
      # perf probe -L page_cgroup_init_flatmem
      Specified source line is not found.
        Error: Failed to show lines.
      -----
    
    There is also another debug error code is shown in the same function
    after get_real_path(). This removes that too.
    Signed-off-by: default avatarMasami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
    Cc: Ingo Molnar <mingo@kernel.org>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Link: http://lkml.kernel.org/r/20140606071406.6788.47850.stgit@kbuild-fedora.novalocalSigned-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
    5ee05b88
probe-event.c 56.3 KB