• Darrick J. Wong's avatar
    xfs: rearrange xfs_da_args a bit to use less space · cda60317
    Darrick J. Wong authored
    A few notes about struct xfs_da_args:
    
    The XFS_ATTR_* flags only go up as far as XFS_ATTR_INCOMPLETE, which
    means that attr_filter could be a u8 field.
    
    I've reduced the number of XFS_DA_OP_* flags down to the point where
    op_flags would also fit into a u8.
    
    filetype has 7 bytes of slack after it, which is wasteful.
    
    namelen will never be greater than MAXNAMELEN, which is 256.  This field
    could be reduced to a short.
    
    Rearrange the fields in xfs_da_args to waste less space.  This reduces
    the structure size from 136 bytes to 128.  Later when we add extra
    fields to support parent pointer replacement, this will only bloat the
    structure to 144 bytes, instead of 168.
    Signed-off-by: default avatarDarrick J. Wong <djwong@kernel.org>
    Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
    cda60317
xfs_da_btree.h 9.01 KB