• Daniel Machon's avatar
    net: microchip: sparx5: fix deletion of existing DSCP mappings · cdd28833
    Daniel Machon authored
    Fix deletion of existing DSCP mappings in the APP table.
    
    Adding and deleting DSCP entries are replicated per-port, since the
    mapping table is global for all ports in the chip. Whenever a mapping
    for a DSCP value already exists, the old mapping is deleted first.
    However, it is only deleted for the specified port. Fix this by calling
    sparx5_dcb_ieee_delapp() instead of dcb_ieee_delapp() as it ought to be.
    
    Reproduce:
    
    // Map and remap DSCP value 63
    $ dcb app add dev eth0 dscp-prio 63:1
    $ dcb app add dev eth0 dscp-prio 63:2
    
    $ dcb app show dev eth0 dscp-prio
    dscp-prio 63:2
    
    $ dcb app show dev eth1 dscp-prio
    dscp-prio 63:1 63:2 <-- 63:1 should not be there
    
    Fixes: 8dcf69a6 ("net: microchip: sparx5: add support for offloading dscp table")
    Signed-off-by: default avatarDaniel Machon <daniel.machon@microchip.com>
    Reviewed-by: default avatarSimon Horman <simon.horman@corigine.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    cdd28833
sparx5_dcb.c 9.98 KB