• Roberto Sassu's avatar
    ima: Return int in the functions to measure a buffer · ce5bb5a8
    Roberto Sassu authored
    ima_measure_critical_data() and process_buffer_measurement() currently
    don't return a result as, unlike appraisal-related functions, the result is
    not used by callers to deny an operation. Measurement-related functions
    instead rely on the audit subsystem to notify the system administrator when
    an error occurs.
    
    However, ima_measure_critical_data() and process_buffer_measurement() are a
    special case, as these are the only functions that can return a buffer
    measurement (for files, there is ima_file_hash()). In a subsequent patch,
    they will be modified to return the calculated digest.
    
    In preparation to return the result of the digest calculation, this patch
    modifies the return type from void to int, and returns 0 if the buffer has
    been successfully measured, a negative value otherwise.
    
    Given that the result of the measurement is still not necessary, this patch
    does not modify the behavior of existing callers by processing the returned
    value. For those, the return value is ignored.
    Signed-off-by: default avatarRoberto Sassu <roberto.sassu@huawei.com>
    Reviewed-by: default avatarLakshmi Ramasubramanian <nramas@linux.microsoft.com>
    Acked-by: Paul Moore <paul@paul-moore.com> (for the SELinux bits)
    Signed-off-by: default avatarMimi Zohar <zohar@linux.ibm.com>
    ce5bb5a8
ima.h 13.6 KB