• Peter Pan(潘卫平)'s avatar
    bonding:reset backup and inactive flag of slave · ba3211cc
    Peter Pan(潘卫平) authored
    Eduard Sinelnikov (eduard.sinelnikov@gmail.com) found that if we change
    bonding mode from active backup to round robin, some slaves are still keeping
    "backup", and won't transmit packets.
    
    As Jay Vosburgh(fubar@us.ibm.com) pointed out that we can work around that by
    removing the bond_is_active_slave() check, because the "backup" flag is only
    meaningful for active backup mode.
    
    But if we just simply ignore the bond_is_active_slave() check,
    the transmission will work fine, but we can't maintain the correct value of
    "backup" flag for each slaves, though it is meaningless for other mode than
    active backup.
    
    I'd like to reset "backup" and "inactive" flag in bond_open,
    thus we can keep the correct value of them.
    
    As for bond_is_active_slave(), I'd like to prepare another patch to handle it.
    
    V2:
    Use C style comment.
    Move read_lock(&bond->curr_slave_lock).
    Replace restore with reset, for active backup mode, it means "restore",
    but for other modes, it means "reset".
    Signed-off-by: default avatarWeiping Pan <panweiping3@gmail.com>
    Reviewed-by: default avatarWANG Cong <xiyou.wangcong@gmail.com>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    ba3211cc
bond_main.c 130 KB