• Josh Poimboeuf's avatar
    x86/unwind: Fix oprofile module link error · cfee9edd
    Josh Poimboeuf authored
    When compiling on x86 with CONFIG_OPROFILE=m and CONFIG_FRAME_POINTER=n,
    the oprofile module fails to link:
    
      ERROR: ftrace_graph_ret_addr" [arch/x86/oprofile/oprofile.ko] undefined!
    
    The problem was introduced when oprofile was converted to use the new
    x86 unwinder.  When frame pointers are disabled, the "guess" unwinder's
    unwind_get_return_address() is an inline function which calls
    ftrace_graph_ret_addr(), which is not exported.
    
    Fix it by converting the "guess" version of unwind_get_return_address()
    to an exported out-of-line function, just like its frame pointer
    counterpart.
    Reported-by: default avatarKarl Beldan <karl.beldan@gmail.com>
    Signed-off-by: default avatarJosh Poimboeuf <jpoimboe@redhat.com>
    Cc: Andy Lutomirski <luto@kernel.org>
    Cc: Borislav Petkov <bp@alien8.de>
    Cc: Brian Gerst <brgerst@gmail.com>
    Cc: Denys Vlasenko <dvlasenk@redhat.com>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: H. Peter Anvin <hpa@zytor.com>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Fixes: ec2ad9cc ("oprofile/x86: Convert x86_backtrace() to use the new unwinder")
    Link: http://lkml.kernel.org/r/be08d589f6474df78364e081c42777e382af9352.1475731632.git.jpoimboe@redhat.comSigned-off-by: default avatarIngo Molnar <mingo@kernel.org>
    cfee9edd
unwind_guess.c 1.23 KB