• Vivek Goyal's avatar
    floppy: fix another use-after-free · d017bf6b
    Vivek Goyal authored
    While scanning the floopy code due to c093ee4f ("floppy: fix
    use-after-free in module load failure path"), I found one more instance
    of trying to access disk->queue pointer after doing put_disk() on
    gendisk.  For some reason , floppy moule still loads/unloads fine.  The
    object is probably still around with right pointer values.
    
     o There seems to be one more instance of trying to cleanup the request
       queue after we have called put_disk() on associated gendisk.
    
     o This fix is more out of code inspection.  Even without this fix for
       some reason I am able to load/unload floppy module without any
       issues.
    
     o Floppy module loads/unloads fine after the fix.
    Signed-off-by: default avatarVivek Goyal <vgoyal@redhat.com>
    Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
    d017bf6b
floppy.c 117 KB