• Eric Biggers's avatar
    block/keyslot-manager: prevent crash when num_slots=1 · 47a84653
    Eric Biggers authored
    If there is only one keyslot, then blk_ksm_init() computes
    slot_hashtable_size=1 and log_slot_ht_size=0.  This causes
    blk_ksm_find_keyslot() to crash later because it uses
    hash_ptr(key, log_slot_ht_size) to find the hash bucket containing the
    key, and hash_ptr() doesn't support the bits == 0 case.
    
    Fix this by making the hash table always have at least 2 buckets.
    
    Tested by running:
    
        kvm-xfstests -c ext4 -g encrypt -m inlinecrypt \
                     -o blk-crypto-fallback.num_keyslots=1
    
    Fixes: 1b262839 ("block: Keyslot Manager for Inline Encryption")
    Signed-off-by: default avatarEric Biggers <ebiggers@google.com>
    Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
    47a84653
keyslot-manager.c 10.9 KB