• Tuong Lien's avatar
    tipc: eliminate the dummy packet in link synching · d0d605c5
    Tuong Lien authored
    When preparing tunnel packets for the link failover or synchronization,
    as for the safe algorithm, we added a dummy packet on the pair link but
    never sent it out. In the case of failover, the pair link will be reset
    anyway. But for link synching, it will always result in retransmission
    of the dummy packet after that.
    We have also observed that such the retransmission at the early stage
    when a new node comes in a large cluster will take some time and hard
    to be done, leading to the repeated retransmit failures and the link is
    reset.
    
    Since in commit 4929a932 ("tipc: optimize link synching mechanism")
    we have already built a dummy 'TUNNEL_PROTOCOL' message on the new link
    for the synchronization, there's no need for the dummy on the pair one,
    this commit will skip it when the new mechanism takes in place. In case
    nothing exists in the pair link's transmq, the link synching will just
    start and stop shortly on the peer side.
    
    The patch is backward compatible.
    Acked-by: default avatarJon Maloy <jon.maloy@ericsson.com>
    Tested-by: default avatarHoang Le <hoang.h.le@dektech.com.au>
    Signed-off-by: default avatarTuong Lien <tuong.t.lien@dektech.com.au>
    Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
    d0d605c5
link.c 75.4 KB